Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(events): update screen after change language #413

Merged
merged 1 commit into from
Oct 2, 2017
Merged

fix(events): update screen after change language #413

merged 1 commit into from
Oct 2, 2017

Conversation

lex111
Copy link
Member

@lex111 lex111 commented Oct 2, 2017

@housseindjirdeh wrote that the screen of events is not updated after changing the language. This PR fixes this, I completely forgot about extraData from FlatList, which is needed for similar purposes 😕

housseindjirdeh
housseindjirdeh approved these changes Oct 2, 2017
View reviewed changes
Copy link
Member

@housseindjirdeh housseindjirdeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was literally just about to start looking into this so I appreciate you taking a look just in time :)

Thanks so much matey 🎉

@housseindjirdeh housseindjirdeh merged commit 53f9a1f into master Oct 2, 2017
@lex111 lex111 deleted the update-events-screen-after-change-lang branch October 2, 2017 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@housseindjirdeh housseindjirdeh housseindjirdeh approved these changes

Assignees
No one assigned
Labels
🐛 bug high priority ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lex111 @housseindjirdeh