-
Notifications
You must be signed in to change notification settings - Fork 787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(translation): Add Galician translation #452
feat(translation): Add Galician translation #452
Conversation
Add ga.js file to .../languages, plus modify some related files BREAKING CHANGE: New translation gitpoint#421
Two things:
|
In fact, it is not yet clear what to do with the flags. But in any case, it does not affect your translation in any way, so do not worry about it yet.
Of course, let's try to figure out what's wrong. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great @siderio2, thank you so much 🙌
Agreed we can decide how we can take care of the different flags once we merge this in. @lex111 I've left a suggestion to use circular avatar images in #421 but I'll defer to you on whatever you think looks nicest :)
Tested on simulator and works wonderfully:
Open in browser
is text that was included super recently, if you could rebase from master and add that string it would be awesome @siderio2, but otherwise not a problem we can always round off any remaining translations before our release.
@@ -34,4 +34,9 @@ export default [ | |||
emojiCode: ':flag-ru:', | |||
name: 'Русский', | |||
}, | |||
{ | |||
code: 'gl', | |||
emojiCode: ':flag_white:', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The list of emoji codes we can use are here. You're right, flag_white
doesn't exist but you can use :waving_white_flag:
to have this 🏳️
Woo awesome glad to hear you got it working mate 🎉 Yeah so the |
Change on flag icon sortcode and updated some details in the translation file BREAKING CHANGE: none none
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So awesome, thank you @siderio2 🎉
@@ -71,6 +70,7 @@ | |||
DC5C35ED1E37AD1800F3F526 /* SimpleLineIcons.ttf in Resources */ = {isa = PBXBuildFile; fileRef = DC5C35E31E37AD1800F3F526 /* SimpleLineIcons.ttf */; }; | |||
DC5C35EE1E37AD1800F3F526 /* Zocial.ttf in Resources */ = {isa = PBXBuildFile; fileRef = DC5C35E41E37AD1800F3F526 /* Zocial.ttf */; }; | |||
EB0F176BE52B4561B9FF07AB /* libReactNativeConfig.a in Frameworks */ = {isa = PBXBuildFile; fileRef = D7043BDB577E427391ECFBB0 /* libReactNativeConfig.a */; }; | |||
CBC20ECDD7FF46A49DF646D6 /* Feather.ttf in Resources */ = {isa = PBXBuildFile; fileRef = 20A722EC74A74B50BD5DCCC9 /* Feather.ttf */; }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have noticed this locally when linking (I'm assuming RNE has a new icon font called Feather
?) Not sure why I just didn't push it to master but perfectly okay to have it in this PR
Add ga.js file to .../languages, plus modify some related files
BREAKING CHANGE: New translation
#421