Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(translation): Add Galician translation #452

Merged

Conversation

siderio2
Copy link
Contributor

@siderio2 siderio2 commented Oct 8, 2017

Add ga.js file to .../languages, plus modify some related files

BREAKING CHANGE: New translation

#421

Add ga.js file to .../languages, plus modify some related files

BREAKING CHANGE: New translation

gitpoint#421
@siderio2
Copy link
Contributor Author

siderio2 commented Oct 8, 2017

Two things:

  1. I have finally used the white flag emoji while the flag system is not changed, but I'm not sure if I'm using it right: all flags included until now have a shortcode like ':flag-pt:', but I have seen that for the white flag it is ':flag_white:'. Does it work??
  2. And I'm asking this because I'm not able to run the app locally on my computer, so it would be nice if someone can check it. I'm going to gitter to ask what am I doing wrong with the local deployment.

@lex111
Copy link
Member

lex111 commented Oct 8, 2017

I have finally used the white flag emoji while the flag system is not changed, but I'm not sure if I'm using it right: all flags included until now have a shortcode like ':flag-pt:', but I have seen that for the white flag it is ':flag_white:'. Does it work??

In fact, it is not yet clear what to do with the flags. But in any case, it does not affect your translation in any way, so do not worry about it yet.

And I'm asking this because I'm not able to run the app locally on my computer, so it would be nice if someone can check it. I'm going to gitter to ask what am I doing wrong with the local deployment.

Of course, let's try to figure out what's wrong.

@andrewda andrewda changed the title feat($translation): Add Galician translation feat(translation): Add Galician translation Oct 8, 2017
Copy link
Member

@housseindjirdeh housseindjirdeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @siderio2, thank you so much 🙌

Agreed we can decide how we can take care of the different flags once we merge this in. @lex111 I've left a suggestion to use circular avatar images in #421 but I'll defer to you on whatever you think looks nicest :)

Tested on simulator and works wonderfully:

galician

Open in browser is text that was included super recently, if you could rebase from master and add that string it would be awesome @siderio2, but otherwise not a problem we can always round off any remaining translations before our release.

@@ -34,4 +34,9 @@ export default [
emojiCode: ':flag-ru:',
name: 'Русский',
},
{
code: 'gl',
emojiCode: ':flag_white:',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The list of emoji codes we can use are here. You're right, flag_white doesn't exist but you can use :waving_white_flag: to have this 🏳️

@housseindjirdeh
Copy link
Member

@lex111 feel free to do a pass through, other than changing the emoji code to :waving_white_flag: it looks good to me.

@siderio2 we would love to help you get the app working on your machine as well. Please let us know whatever issue you might be seeing and we'll help 🙌

@siderio2
Copy link
Contributor Author

siderio2 commented Oct 8, 2017

Well, it took me more than expected, but I finally managed to run the app on my machine. I already changed the flag shortcode, but it doesn't work on my phone (Redmi note 4 with android 6.0). And also I see a string not translated in options: 'Open in Browser', but I can't find it...

screenshot_2017-10-08-19-08-43-134_com gitpoint

@housseindjirdeh
Copy link
Member

Woo awesome glad to hear you got it working mate 🎉

Yeah so the Open in Browser string was merged just recently so you'll have to rebase/merge from master to see the line in en.js. And hmm interesting how the icon doesn't show. Don't worry about that, @lex111 and I are already discussing replacing all those emojicodes with circular images anyway :)

Change on flag icon sortcode and updated some details in the translation file

BREAKING CHANGE: none

none
Copy link
Member

@housseindjirdeh housseindjirdeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So awesome, thank you @siderio2 🎉

@@ -71,6 +70,7 @@
DC5C35ED1E37AD1800F3F526 /* SimpleLineIcons.ttf in Resources */ = {isa = PBXBuildFile; fileRef = DC5C35E31E37AD1800F3F526 /* SimpleLineIcons.ttf */; };
DC5C35EE1E37AD1800F3F526 /* Zocial.ttf in Resources */ = {isa = PBXBuildFile; fileRef = DC5C35E41E37AD1800F3F526 /* Zocial.ttf */; };
EB0F176BE52B4561B9FF07AB /* libReactNativeConfig.a in Frameworks */ = {isa = PBXBuildFile; fileRef = D7043BDB577E427391ECFBB0 /* libReactNativeConfig.a */; };
CBC20ECDD7FF46A49DF646D6 /* Feather.ttf in Resources */ = {isa = PBXBuildFile; fileRef = 20A722EC74A74B50BD5DCCC9 /* Feather.ttf */; };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have noticed this locally when linking (I'm assuming RNE has a new icon font called Feather?) Not sure why I just didn't push it to master but perfectly okay to have it in this PR

@housseindjirdeh housseindjirdeh merged commit 98e5880 into gitpoint:master Oct 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants