fix(sc): Fix by stylelint #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lex111
approved these changes
Nov 2, 2017
andrewda
requested changes
Nov 2, 2017
| @@ -25,7 +25,7 @@ const StyledListItem = styled(ListItem).attrs({ | |||
| }, | |||
| underlayColor: props => (props.unknown ? null : colors.greyLight), | |||
| hideChevron: props => props.unknown, | |||
| }); | |||
| })``; | |||
There was a problem hiding this comment.
@andrewda It is just my last commit, whose purpose is reverting changes. I removed them by mistake, because stylelint complained about empty blocks, as the updated PR description mentioned. But we can't simply do that. "fn``" is different with "fn".
There was a problem hiding this comment.
Ah ok yea, didn't see that that was a revert commit.
| @@ -40,7 +40,7 @@ const CloseIcon = styled(Icon).attrs({ | |||
| size: 28, | |||
| name: 'x', | |||
| type: 'octicon', | |||
| }); | |||
| })``; | |||
andrewda
approved these changes
Nov 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP.Modified by stylelint's suggestions. Including:
padding-horizonalThe last thing is that, is there a better way for empty tagged template?
stylelintwill throw a warning. Of course, maybe we can add a rule to ignore it.