feat(repository): Show issues only when is enable #328
Conversation
| @@ -353,20 +358,25 @@ class Repository extends Component { | |||
| </SectionList> | |||
|
|
|||
| {!repository.fork && | |||
| repository.has_issues && ( | |||
There was a problem hiding this comment.
To be honest, that is the only real change, all other changes were made by the pre-commit hook.
There was a problem hiding this comment.
Yep no worries, we're using prettier (https://prettier.io/) and attached it as a precommit step :)
Not sure this is the solution to the issue however. As a user, I still want to be able ot add a new issue when there are no issues present and removing the section entirely won't help that. I think the issue was referring to removing the New Issue button only if adding new issues aren't enabled rather than the entire SectionList (and I'm not sure the has_issues attribute is for this). Does that make sense mate?
There was a problem hiding this comment.
Cool, so I didn't destroy anything 😄
So I've tested in one repository and on the github site the whole section is removed when we disable the issue option, So I thought that could be better just remove the section in the app as well.
Ps. This has_issue field is a flag to describe if the repository has issue feature or not.
https://developer.github.com/v3/repos/
There was a problem hiding this comment.
Oooooh my apologies you're right, and here I thought it meant if was a boolean that that returned based on issues.length :P
Thanks my man, this is awesome thank you for this 👏
Closes #296