Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(build): fix styled components errors #572

Merged
merged 1 commit into from
Oct 24, 2017
Merged

fix(build): fix styled components errors #572

merged 1 commit into from
Oct 24, 2017

Conversation

alejandronanez
Copy link
Member

This was breaking master for 1.4
Related to #569

@coveralls
Copy link

Coverage Status

Coverage remained the same at 29.497% when pulling 5ac2cd8 on fix-styled-components-typos into df9555a on master.

@alejandronanez alejandronanez merged commit aa22d8a into master Oct 24, 2017
@alejandronanez alejandronanez deleted the fix-styled-components-typos branch October 24, 2017 03:30
@machour
Copy link
Member

machour commented Oct 24, 2017

It's not the first time a styled-component merged PR breaks the app. We should be more careful with manual tests before merging.

@andrewda
Copy link
Member

Getting detox set up would be awesome.

@andrewda andrewda mentioned this pull request Oct 24, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewda andrewda andrewda approved these changes

@housseindjirdeh housseindjirdeh Awaiting requested review from housseindjirdeh

Assignees
No one assigned
Labels
🐛 bug crash
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alejandronanez @coveralls @machour @andrewda @chinesedfan