Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not support universal wheels #31

Merged
merged 1 commit into from
Sep 24, 2016

Conversation

graingert
Copy link
Contributor

because you need to build manylinux1/mac/windows wheels instead

because you need to build manylinux1/mac/windows wheels instead
@graingert
Copy link
Contributor Author

although it's probably best to split this repo again into pure python and .c

@Byron
Copy link
Member

Byron commented Sep 24, 2016

As I am not quite sure about the impact of the C-code and the overall maintenance and distribution burden, I would rather remove it entirely.

In the current implementation using setup.py it would try to build the code, and just keep going on failure. Something like that I would love to have for the wheel as well.
Alternatively, maybe it's possible to keep supporting the setup.py for those who want to have a chance to improved performance, and those who use wheels will still get the python-only version.

I will just merge the commit for now, but do indeed hope there is a way to make this work.

@Byron Byron merged commit 847a21e into gitpython-developers:master Sep 24, 2016
@graingert
Copy link
Contributor Author

I've pulled the C out into https://github.com/graingert/gitdb-speedups

This can now be optionally installed by those who need the speed

@Byron
Copy link
Member

Byron commented Oct 9, 2016

@graingert Thanks a lot - I have left a comment in the respective PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants