Scrollbar layout #115
Merged
Scrollbar layout #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As VueScrollbar requires a height and based on which it can create a scrollbar.
|
Refs in the workspace page are not able to return the height of the element using the computed property. |
mittalyashu
added a commit
that referenced
this pull request
Jul 8, 2019
* TFlexbox layout (#128) * Create TFlexbox layout component * Apply TFlexbox layout component * Flexbox the repository index view * Use TFlexbox layout to menubar * Use TFlexbox layout component * Use TFlexbox to windowsButton component * Add flexGrow props to TFlexbox props * Switch from flex classes to TFlexbox layout component * Use TFlexbox layout component * TFlexbox in dropdownList component * TFlexbox in commitInformation component * TFlexbox in commitHistoryItem component * Scrollbar layout (#115) * Create scrollbar layout component * Add height props to TScrollbar component As VueScrollbar requires a height and based on which it can create a scrollbar. * Use TScrollbar component * Change to TScrollbar component in diffPreview * Use TScrollbar layout component * Add refs for calculating size of elements * Change TScrollbar layout component * Use TFlexbox to experimental page * TContainer layout (#137) * Create TContainer layout component * Remove container.sass styles * Fix menubar dropdown toggle * Container fluid props * Add width props to TScrollbar * Use TContainer in settings page * Use TContainer in repository stats * Use TContainer in repository settings * Set width 100% & static height * Format the indentation of codebase * Set root element size to 1000% * Use flexbox layout for group settings * Calculate height inline height attribute * Add flexbox styles to t-flexbox layout * Bug fix: Duplicate key 'components' https://dev.azure.com/codecarrot/Thermal/_build/results?buildId=715&view=logs&jobId=03c9b7aa-3025-5776-c20a-35d2538e500f&taskId=e9b0d7bb-2e43-53fa-b0ce-11002919699b&lineStart=104&lineEnd=104&colStart=49&colEnd=75 * Add css class styles to experimental items Add css class style "settings__section__group__item" * Center welcome page heading * Remove flexbox class styles * FIX: Example repository modal positioning * BlankSlate placeholder (#129) * Create BlankSlate placeholder component * Remove flex-direction style from BlankSlate * Import BlankSlate component * Format the code * Change to default value to null of height props Remove required as true in height props and set default value as null. * Manually calculate height of scrollbar * Set 300px min width of history logs * Set history page to flex grow 1 * Optamize performace: Display of logs & commit detail Improve performace by not removing history logs list from DOM and just display none when commit detail is enabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.