Skip to content
This repository has been archived by the owner on Feb 8, 2018. It is now read-only.

Send additional address info to Balanced; #2446 #2448

Merged
merged 2 commits into from
May 30, 2014
Merged

Conversation

chadwhitacre
Copy link
Contributor

@chadwhitacre
Copy link
Contributor Author

@mjallday @msherry I'm trying to test out this branch by using the Gittip CC form with a test marketplace. I'm looking at this card on the dashboard:

https://dashboard.balancedpayments.com/#/marketplaces/TEST-MP1wTyxDAJKCaWPjBS4Oli4d/cards/CCJVCqX52wbthdR2l1piCWD

screen shot 2014-05-29 at 10 54 41 pm

I see country, city_town, and address_2 under "Card info." I guess those are coming from credit_card.meta (though where is region?). That's fine. And it looks like the ZIP code is coming through. Should I expect to see the rest of credit_card.address end up somewhere in the dashboard?

@mjallday
Copy link
Contributor

In your code you're setting country, not country_code.

image

We've opened an issue to get the address details to display on the Balanced dashboard, I used the chome inspector to look at the raw API response in the meantime :/

@chadwhitacre
Copy link
Contributor Author

Ah, cool. Thanks for the catch! :-)

@chadwhitacre
Copy link
Contributor Author

Confirmed!

screen shot 2014-05-30 at 5 38 28 pm

@chadwhitacre
Copy link
Contributor Author

Ready for review @seanlinsley @clone1018 @ESWAT @ivanmushketyk @Changaco et al.

@seanlinsley
Copy link
Contributor

Using my own test marketplace, this looks to have done the trick.

seanlinsley added a commit that referenced this pull request May 30, 2014
Send additional address info to Balanced; #2446
@seanlinsley seanlinsley merged commit 6206f4b into master May 30, 2014
@seanlinsley seanlinsley deleted the cc-country branch May 30, 2014 23:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants