Add fRequireStandardConsensus global and -allownonstdtxnconsensus option #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EyeOfPython
force-pushed
the
require_standard_consensus
branch
7 times, most recently
from
ff37777
to
66af577
Compare
EyeOfPython
changed the title
EyeOfPython
force-pushed
the
require_standard_consensus
branch
2 times, most recently
from
8d47e0f
to
b500626
Compare
schancel
reviewed
Mar 7, 2021
| // Enforce standardness on all txs. | ||
| if (fRequireStandardConsensus) { | ||
| std::string reason; | ||
| if (!IsStandardTx(tx, fIsBareMultisigStd, CFeeRate(Amount::zero()), |
There was a problem hiding this comment.
I'm having PTSD looking at this.
EyeOfPython
force-pushed
the
require_standard_consensus
branch
2 times, most recently
from
caecc70
to
0354ad7
Compare
EyeOfPython
force-pushed
the
require_standard_consensus
branch
from
0354ad7
to
9eefdd2
Compare
This was referenced Mar 7, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fRequireStandardConsensusflag:-allownonstdtxnconsensusoption (defaults to-acceptnonstdtxn) to disable the above behavior.-allownonstdtxnconsensus=1by default for tests inBasicTestingSetup.-allownonstdtxnconsensus=1in functional tests that depend on non-standard txs in blocks, but which didn't enable-acceptnonstdtxn.