Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display dialog when BT is OFF (KIDS-668) #483

Merged
merged 3 commits into from
Mar 24, 2024

Conversation

alexbejann
Copy link
Contributor

@alexbejann alexbejann commented Dec 22, 2023

Description

  • I added a dialog to be displayed when the iOS user has the BT off and unauthorized

@github-actions github-actions bot added the bug Something isn't working label Dec 22, 2023
@@ -99,7 +121,7 @@ class _BTScanPageState extends State<BTScanPage> {

void _onPeripheralsDetectedData(List<ScanResult> results) {
for (final scanResult in results) {
if (scanResult.advertisementData.localName.isEmpty) {
if (scanResult.advertisementData.advName.isEmpty) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the difference? The solution did work :-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

localName is deprecated and I found that advName does the same

Copy link
Contributor

@MaikelStuivenberg MaikelStuivenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment

@MaikelStuivenberg MaikelStuivenberg merged commit a87c7a7 into develop Mar 24, 2024
1 check passed
@MaikelStuivenberg MaikelStuivenberg deleted the fix/bff-1422/bluetooth-ios branch March 24, 2024 20:48
@MaikelStuivenberg MaikelStuivenberg changed the title BFF-1422 Display dialog when BT is OFF Display dialog when BT is OFF (KIDS-668) Mar 24, 2024
@alexbejann
Copy link
Contributor Author

alexbejann commented Mar 25, 2024

That took some time to be merged haha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants