Generosity challenge - day 2 - assignment - select family values (kids-923) #711

Daniela510 · 2024-05-02T15:36:42Z

Description

Overview of changes:

Added a DailyAssignmentCubit to keep track of assignments that have a flow between giving assignment and completion. Right now this is specifically about day 2 and day 7.
From design, day 2 and day 7 when the assignment card is split in 2 parts, the second part is filled in by user choices, on day 2 is the selected values on day 7 it will be a recap of the donation.
Also looking at the design it seems the banner mage will be the same every day, the top label is also static, and the banner title is the same as the assignment title so i removed the feedback fields as they seemed redundant.
The family values selection feature is in subfolder assignments & happens on a sub-route of the generosity challenge.

…ect-family-values

pavelpavelko · 2024-05-03T08:13:12Z

lib/app/routes/pages.dart

@@ -11,6 +11,10 @@ enum Pages {
    path: '/generosity-challenge',
    name: 'GENEROSITY-CHALLENGE',
  ),
+  generositySelectValues(
+    path: 'select-values',


let's add "generosity-..." for consistency

I would reather remove generosity from the title to make it selectValues(path: 'select-values',) since it is on the generosity sub-route.

makes sense bc of sub route, I didn't think about it)

pavelpavelko · 2024-05-03T08:16:28Z

lib/features/children/generosity_challenge/assignments/family_values/models/family_value.dart

+    required this.area,
+  });
+
+  factory FamilyValue.fromJson(Map<String, dynamic> json) {


perhaps fromMap/toMap would be more consistent?

pavelpavelko · 2024-05-03T08:18:13Z

...children/generosity_challenge/assignments/family_values/pages/select_family_values_page.dart

+                        mainAxisAlignment: MainAxisAlignment.spaceBetween,
+                        children: [
+                          Text(
+                            'Select 3 values',


shall we use FamilyValuesState.maxSelectedValues here?

pavelpavelko · 2024-05-03T08:19:44Z

...en/generosity_challenge/assignments/family_values/repositories/family_values_repository.dart

+
+mixin FamilyValuesRepository {
+  Future<bool> rememberValues({
+    required List<Map<String, dynamic>> body,


why do we use map here instead of List?

Its of list of maps because its a list of family values, i could wrap the list in a map to be something like:

{"values" : [ { ... }, { ... }, ] }

But i am not sure what would be the utility of that?

'Its of list of maps because its a list of family values' - yes, and that's ok. I think repository is a good place for data translation from model to map and to json string and backward instead of doing it in the cubit

I mean this part:
final selectedValuesJson = state.selectedValues.map((e) => e.toMap()).toList();

Ooh! Yes totally, thank you for the direction 🙏

pavelpavelko · 2024-05-03T08:25:11Z

lib/features/children/generosity_challenge/models/task.dart

@@ -12,21 +12,18 @@ class Task extends Equatable {
    required this.description,
    required this.onTap,
    required this.buttonText,
-    required this.feedbackImage,


I would suggest to keep feedback per day logic since it's already implemented and can be useful for upcoming challenges, even if we do not use it for the current one (I assume bc of simplification).

pavelpavelko · 2024-05-03T08:28:10Z

lib/features/children/generosity_challenge/pages/generosity_challenge_day_details.dart

+                        'day': challenge.state.detailedDayIndex + 1,
+                      },
+                    );
+                    await challenge.completeActiveDay();


at this point I wanna ask why don't we use GenerosityChallengeCubit for it? Isn't DailyAssignmentCubit look redundant?

I wanted to use smaller, more 'focused', but youu are right, one more GenerosityChallengeStatus would work as well

pavelpavelko · 2024-05-03T08:29:29Z

lib/features/children/generosity_challenge/utils/family_values_content_helper.dart

+      imagePath:
+          'https://givtstoragedebug.blob.core.windows.net/public/cdn/tag-logos/aid.svg',
+      colorCombo: ColorCombo.highlight,
+      interestKeys: ['AFTERADISASTER'],


let's put these values in enums for both interestKeys and area

…ect-family-values # Conflicts: # lib/app/injection/injection.dart

pavelpavelko

Good job Daniela!

Daniela Damaschin added 6 commits May 1, 2024 14:32

set up assignment with flow in between

4bba410

Display family values

5b0b4b3

Family value selection flow

1c321c3

Merge branch 'develop' into feature/kids-923-generosity-challenge-sel…

764e0c5

…ect-family-values

Finishing logic of remembering values as json

9254e34

remove unused

c319e4d

github-actions bot added the enhancement New feature or request label May 2, 2024

clean up

e4f9897

Daniela510 marked this pull request as ready for review May 2, 2024 16:02

Daniela510 requested a review from a team as a code owner May 2, 2024 16:02

Daniela510 changed the title ~~Generosity challenge - day 2 - assignment - select family values (kids 923)~~ Generosity challenge - day 2 - assignment - select family values (kids-923) May 2, 2024

pavelpavelko reviewed May 3, 2024

View reviewed changes

Daniela Damaschin added 8 commits May 3, 2024 13:31

pr improve naming

1a2ecbf

remove the dailyassignmentcubit

0372294

color fix

cc8ab5b

Merge branch 'develop' into feature/kids-923-generosity-challenge-sel…

92b9948

…ect-family-values # Conflicts: # lib/app/injection/injection.dart

area and interest enums

c1edc78

translate family values into list in the repository

bd7f061

add logging

323f23f

remove navigating page hack

c9e5a14

pavelpavelko approved these changes May 3, 2024

View reviewed changes

Daniela510 merged commit 21a3a96 into develop May 3, 2024
1 check passed

Daniela510 deleted the feature/kids-923-generosity-challenge-select-family-values branch May 3, 2024 12:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Generosity challenge - day 2 - assignment - select family values (kids-923) #711

Generosity challenge - day 2 - assignment - select family values (kids-923) #711

Daniela510 commented May 2, 2024 •

edited

Loading

pavelpavelko May 3, 2024

Daniela510 May 3, 2024

pavelpavelko May 3, 2024

pavelpavelko May 3, 2024

pavelpavelko May 3, 2024

pavelpavelko May 3, 2024

Daniela510 May 3, 2024

pavelpavelko May 3, 2024

pavelpavelko May 3, 2024

Daniela510 May 3, 2024

pavelpavelko May 3, 2024

pavelpavelko May 3, 2024

Daniela510 May 3, 2024

Daniela510 May 3, 2024

pavelpavelko May 3, 2024

pavelpavelko left a comment

Generosity challenge - day 2 - assignment - select family values (kids-923) #711

Generosity challenge - day 2 - assignment - select family values (kids-923) #711

Conversation

Daniela510 commented May 2, 2024 • edited Loading

Description

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pavelpavelko left a comment

Choose a reason for hiding this comment

Daniela510 commented May 2, 2024 •

edited

Loading