Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add day 1 task content (kids-882) #713

Merged
merged 1 commit into from
May 7, 2024
Merged

Add day 1 task content (kids-882) #713

merged 1 commit into from
May 7, 2024

Conversation

Daniela510
Copy link
Contributor

Description

  • task content
  • banner already works also, it takes the title of the task as the banner title unless provided otherwise. And in this case its the same.

@Daniela510 Daniela510 requested a review from a team as a code owner May 6, 2024 14:29
@github-actions github-actions bot added the enhancement New feature or request label May 6, 2024
TammiLion
TammiLion reviewed May 6, 2024
View reviewed changes
lib/features/children/generosity_challenge/utils/generosity_challenge_content_helper.dart
description:
"Lived a craftsman Geppetto. One day he decided to make a wooden toy. He said to himself, 'I will make a little boy and call him Pinocchio.'",
"Today's assignment is for each family member to answer the question on the Mayor's letter. Once you've done that, stick it on your fridge with the magnet where you will see it everyday!\n\nDone? Hit the Complete Button",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's supposed to be "in the Mayor's letter" and not "on".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TammiLion according to the design it's on :) But we can ask Andy

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I asked andy. It's in indeed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for checking!

TammiLion
TammiLion approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@TammiLion TammiLion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a comment but otherwise looks ok.

@Daniela510 Daniela510 merged commit e1bd7dd into develop May 7, 2024
1 check passed
@Daniela510 Daniela510 deleted the feature/kids-882-assignment-content branch May 7, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaikelStuivenberg MaikelStuivenberg MaikelStuivenberg left review comments

@TammiLion TammiLion TammiLion approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Daniela510 @TammiLion @MaikelStuivenberg