Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Fixed Point Q5.26 with Q8.23 #67

Merged
merged 4 commits into from
May 25, 2023
Merged

Conversation

raphaelDkhn
Copy link
Collaborator

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

  • Currently, the fixed point is a Q5.26, which only allows us to represent numbers in the range 0 to 31.

Issue Number: N/A

What is the new behavior?

  • Replace Q5.26 with Q8.23, which is a better design for 8-bit quantization tasks.

Does this introduce a breaking change?

  • Yes
  • No

Other information

| function | description |
| --------------------------------------------------- | ----------------------------------------------------------------------------------------------- |
| [`fp.new`](fp.new.md) | Constructs a new `FixedType` instance. |
| [`fp.new_unscaled`](fp.new_unscaled.md) | Creates a new `FixedType` instance with the specified unscaled magnitude and sign. |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this correct without the \_?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the links will be updated manually on gitbook UI

@raphaelDkhn raphaelDkhn merged commit 9649b61 into main May 25, 2023
@franalgaba franalgaba deleted the redesign-fixed-point branch May 25, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants