-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New versions of node break the build #112
Comments
I also had a problem with a newer Node version (12.15.0):
Fixed and successfully deployed using Node 10.20.1 |
Same problem here with a deployment using Heroku.
Edit : The version of node was wrong. The error was solved by adding this to
|
This is suddenly failing for me, I hadn't done any change to the config and had been able to deploy just fine, with Node 14, but then I started getting:
I have tried upgrading the Heroku stack, and also to the latest versions of Node and NPM in my
But I still get that error:
I double-checked and Node 20.2.0 is available in Heroku. I also tried with 20.1.0 and also fails. |
I've encountered the same issue just now. No changes to buildpack config/node versions, but suddenly it keeps failing. Same error as everyone else. Npm/node versions:
|
Thanks for the confirmation @pankamyk - I've submitted a ticket to Heroku. |
We're experiencing same issue here. It seems it fails on this line https://github.com/gjaldon/heroku-buildpack-phoenix-static/blob/master/lib/build.sh#LL28C30-L28C176 and it looks like https://nodebin.herokai.com is down.
|
I can confirm that it looks like the root of this problem lies in the
|
FYI, before forking myself found out that gigalixir's fork fixed it 😄 |
Cool @mracos - I can confirm that deploys work fine with Gigalixir's fork 👍 |
Hi - Heroku did run a brownout on nodebin.herokai.com. Heroku has removed all dependencies on that service and hasn't used it internally for 4 years. The service will be decommissioned very soon. I'd heavily suggest removing the dependency from this buildpack. Gigalixir's fork will likely work as a short term fix, though keep in mind that both are very old forks of https://github.com/heroku/heroku-buildpack-nodejs, so I'd suggest using the latter if possible. |
Heroku informed me that the URL https://nodebin.herokai.com/ works again now. Still, thanks for the warning that it will be decommissioned soon @joshwlewis - let's remove that dependency. |
Same issue started happening for me today, I when I run the same command as mentioned above I also see
|
Using Gigalixir's fork instead of this buildpack works fine. |
Sadly the official buildpack only supports projects with a root-level package.json. There's a dirty hack to fix this but it ain't pretty. |
It does but that is obviously a very temporary fix as others have pointed out. I'd be open to contributing to updates for this buildpack, but I think it'd be really helpful to have some contributing guidelines on the repository if anyone who's worked on it before is happy to put those together? |
Is this buildpack even maintained anymore? |
When I tried building with node js 1.14+ i got this error:
And the whole deployment would fail.
However, when I used version 10.20.1 (because that's the version used in the phoenix docs) it just suddenly did work. I did not test for any versions in between that one and 1.14.0
The text was updated successfully, but these errors were encountered: