Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

does not find any addresses with numbers #10

Closed
beatstick opened this issue Jan 13, 2020 · 15 comments
Closed

does not find any addresses with numbers #10

beatstick opened this issue Jan 13, 2020 · 15 comments

Comments

@beatstick
Copy link

Hi,
when I enter an address containing a number the search does not find anything.

for example Hauptstraße, München is found, but there are no results for Hauptstraße 42, München, or Hauptstraße 42 München. If I enter an address without number and click on it there sometimes is a very brief pop-up for Street numbers etc, but the app just opens Osmand without giving me time to enter any further specifics.

Phone used: MotoG falcon lineageos based on Android 7.1.

@gjedeer
Copy link
Owner

gjedeer commented Jan 14, 2020

Hi,

Sorry but I can't help. Whatever you can't find here https://photon.komoot.de/ can't be found in the app too.They have an issue tracker so you may try your luck there, though it looks like they're very short on developers and don't fix too many bugs.

@ghost
Copy link

ghost commented Mar 31, 2021

When I search for my address on https://photon.komoot.io/ (eg. 123 Street Na) it shows up, but when I search in Acastus nothing shows up. This happens both with location on and off.

gjedeer added a commit that referenced this issue Apr 7, 2021
@gjedeer
Copy link
Owner

gjedeer commented Apr 7, 2021

Looks like the API URL changed (from .de to .io).

I don't currently have a way to build 99c9289 which fixes that - my main computer crashed. If @Cliveptr or someone else interested wants to build an APK out of it and test if it fixes the issue, I'd be grateful.

@ghost
Copy link

ghost commented Apr 7, 2021

I finally figured out how to build it, same thing happens. Let me know if you need a debug build.

app-release.zip

@beatstick
Copy link
Author

@Cliveptr: I just tested your release on calyxos (android 11). And still have the same issue. As soon as I enter a street number, the app does not find any address.

gjedeer added a commit that referenced this issue Apr 8, 2021
@gjedeer
Copy link
Owner

gjedeer commented Apr 8, 2021

Thank you for the build @Cliveptr - found an exception in logcat:

04-08 11:48:50.816 W/System.err(12386): org.json.JSONException: No value for name
04-08 11:48:50.817 W/System.err(12386): 	at org.json.JSONObject.get(JSONObject.java:392)
04-08 11:48:50.817 W/System.err(12386): 	at org.json.JSONObject.getString(JSONObject.java:553)
04-08 11:48:50.817 W/System.err(12386): 	at name.gdr.acastus_photon.MainActivity.fillLists(MainActivity.java:781)
04-08 11:48:50.817 W/System.err(12386): 	at name.gdr.acastus_photon.MainActivity.fetchSearchResults(MainActivity.java:839)
04-08 11:48:50.817 W/System.err(12386): 	at name.gdr.acastus_photon.MainActivity.access$1000(MainActivity.java:57)
04-08 11:48:50.817 W/System.err(12386): 	at name.gdr.acastus_photon.MainActivity$GetResults.doInBackground(MainActivity.java:894)
04-08 11:48:50.817 W/System.err(12386): 	at name.gdr.acastus_photon.MainActivity$GetResults.doInBackground(MainActivity.java:882)
04-08 11:48:50.817 W/System.err(12386): 	at android.os.AsyncTask$2.call(AsyncTask.java:333)
04-08 11:48:50.817 W/System.err(12386): 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
04-08 11:48:50.817 W/System.err(12386): 	at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:245)
04-08 11:48:50.817 W/System.err(12386): 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1162)
04-08 11:48:50.817 W/System.err(12386): 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:636)
04-08 11:48:50.817 W/System.err(12386): 	at java.lang.Thread.run(Thread.java:764)

Untested fix: f7c79ee

gjedeer added a commit that referenced this issue Apr 8, 2021
@gjedeer
Copy link
Owner

gjedeer commented Apr 8, 2021

This one passes the CI: dca635e

@ghost
Copy link

ghost commented Apr 8, 2021

It worked, thanks :)

Off topic, but do you know if anything could be done about OsmAnd showing "house)(house" when I open the address?

app-release.zip

@gjedeer
Copy link
Owner

gjedeer commented Apr 8, 2021

Ooh, that's ugly, "house" also stays in the search history... I see why it's happening but it's a more complicated issue - I would need to generate a nicer name for search results where Photon does not return a name.

@ghost
Copy link

ghost commented Apr 8, 2021

Didn't notice that - what about just using the address as returned by Photon in that case?

@beatstick
Copy link
Author

@Cliveptr:

I just wanted to confirm the address lookup works with the latest apk provided above.
Big thanks to everyone involved!

@k3b
Copy link
Collaborator

k3b commented Apr 13, 2021

@gjedeer : Thanks for fixing this.

I Verified that this is working on my android-10 device.

The Fix will be available in next F-Droid relese 1.22 #15

@k3b k3b closed this as completed Apr 13, 2021
@gjedeer
Copy link
Owner

gjedeer commented Apr 15, 2021

Hey @k3b thank you - but it's not fully fixed yet... See what's saved in search history when you click on a search result which is an address with number.

I haven't found the time to fully fix it yet, feel free to jump in if you have the time. Just using the full found address as a name would fix search results (name = {city}, {street} {housenumber}). But then, search results would display the address double, so it needs further workarounds.

@k3b
Copy link
Collaborator

k3b commented Apr 15, 2021

Sorry i was to fast and not aware that there are issues left. i only checked thag find image with number worked for me

@gjedeer
Copy link
Owner

gjedeer commented Apr 15, 2021

I think 5569e03 fixes the labels issue. @Cliveptr can you confirm the OsmAnd label is as expected now?

gjedeer added a commit that referenced this issue Apr 15, 2021
@k3b k3b closed this as completed Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants