Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pandas compat #143

Merged
merged 1 commit into from
Mar 24, 2022
Merged

Pandas compat #143

merged 1 commit into from
Mar 24, 2022

Conversation

TomAugspurger
Copy link
Contributor

pandas has deprecated using the Float64Index constructor directly, in favor of Index(..., dtype="float64").

I also opened pandas-dev/pandas#46484, to track support for a version of RangeIndex that can support floats.

Float64Index -> Index
@gjoseph92 gjoseph92 merged commit a1816bc into gjoseph92:main Mar 24, 2022
@gjoseph92
Copy link
Owner

Thanks @TomAugspurger!

@TomAugspurger TomAugspurger deleted the fix/pandas-compat branch April 12, 2022 13:19
@TomAugspurger
Copy link
Contributor Author

@gjoseph92 do you have any bandwidth to cut a release with this? Our next set of environments will include a pandas where this deprecation warning is present. No worries if not, we're able to silence specific warnings if necessary.

@gjoseph92
Copy link
Owner

Sure, I can do that in the next few days.

@gjoseph92
Copy link
Owner

gjoseph92 commented Apr 12, 2022

Also just FYI @TomAugspurger, you might want to keep dask and distributed at 2022.1.1 for now. There are a number of stability issues with newer distributed versions that haven't been resolved yet (xref dask/community#238).

@TomAugspurger
Copy link
Contributor Author

Thanks for the heads up. Via https://github.com/conda-forge/pangeo-dask-feedstock/blob/main/recipe/meta.yaml we're pinned to 2022.2.1.

I've been using it for a week or so and haven't noticed anything anecdotally. I'll do a bit more load testing and will report on dask/community#238 if I spot issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants