Explicitly pass dtype during dataset read #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 17, 2023
weiji14
added a commit
to weiji14/zen3geo
that referenced
this pull request
Sep 21, 2023
The latest stackstac 0.5.0 version installed via readthedocs does sets the dtype on read-in using rasterio, instead of after reading with `np.astype`, see gjoseph92/stackstac#208. Ideally, this should be fixed upstream in rasterio and GDAL by supporting reading of GeoTIFFs into float16 dtype. Alternative is to cast to float32 instead, though it would be a waste of memory if doing 16-bit precision training.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We weren't asking rasterio for arrays of the output dtype, so we'd just get whatever the native dtype was of the GeoTIFF. If the GeoTIFF was an integer dtype, but specified floating-point scale/offset, then applying the scaling would fail. This basically moves the cast-to-output-dtype before applying scaling, so whatever you pass for
dtype=(float64 by default) will actually control it.Closes #206