Capitalize symbol names #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ooh, fun! I'll fix up the Windows builds on this branch (sorry about that!) and then merge and release. |
|
No worries! It's not urgent at all. I just wanted to get us in a good place if someone ever needed ruby-enum to be at a higher version. |
added 3 commits
March 6, 2017 16:38
|
Thank you @kivikakk ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another project I use ran into the same problem as #35. I didn't want to lock those dependencies down so I decided to investigate: dblock/ruby-enum#17.
This PR makes all the enum symbol names uppercase, which is apparently required.
@kivikakk Apparently the Windows builds have been failing looking for
cmarkextensions. Any clue why that may be?