Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No cmake required! #60

Merged
merged 5 commits into from
Dec 5, 2017
Merged

No cmake required! #60

merged 5 commits into from
Dec 5, 2017

Conversation

kivikakk
Copy link
Collaborator

@kivikakk kivikakk commented Dec 5, 2017

WHATAMESS

We import the source tree, à la cmark-gfm-hs, with a Makefile to assist maintainers to pull the changes in. We don't need a LOT of extra extconf.rb messing around, since it just all compiles together clean.

There's one line (left commented) in extconf.rb I'm unsure about whether it'd be required on Windows; will wait on AppVeyor to complain or not. gone

/cc @gjtorikian

@gjtorikian
Copy link
Owner

🙀

How come the individual C files need to be brought in here into ext/commonmarker/? Can't the Makefile build cmark's src dir ?

@kivikakk
Copy link
Collaborator Author

kivikakk commented Dec 5, 2017

NOPE. Tried that, and mkmf was like "lol, I see your sources, and will acknowledge that their objects should be part of the resulting build … but I won't build them 😉 "

(╯°□°)╯︵ ┻━┻

@kivikakk
Copy link
Collaborator Author

kivikakk commented Dec 5, 2017

(it only looks in srcdir, and there can only be one srcdir)

@kivikakk
Copy link
Collaborator Author

kivikakk commented Dec 5, 2017

(so even if you specify all the sources in $srcs, if they're not found in srcdir, the resulting Makefile just won't see them and build them, but their objects will still be listed in OBJS and you'll get this:

screen shot 2017-12-06 at 8 23 16 am

(/ .□.)\ ︵╰(゜Д゜)╯︵ /(.□. ))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants