adding "details" to tag whitelist #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since we already include |
|
awesome! thanks guys |
|
just out of interest - what's the time frame for this going into a new release of the gem? many thanks in advance |
|
It looks like it was already released. I'm hoping to pull the latest release into GitHub this week. |
|
awesome - thanks for keeping me in the loop :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies if this pull request is to the wrong branch, or in any fashion inappropriate. It's to support this feature request: #138 which comes from my desire to use summary/detail tag combinations in github markdown. I'm assuming that if the summary tag is acceptable, then the detail tag is okay too?
I've run the tests locally and they all pass (for ruby-2.1.2). Hoping that this can get into a new version and then into github markup so that everyone can enjoy details/summary goodness in their Github READMEs :-)
I've tested them against all the supported rubies in your submissions guidelines. All good, although some of those rubies are not the latest security releases:
ree-1.8.7-2011.03 1.9.2-p290 1.9.3-p429 2.0.0-p247
did you want to upgrade your submissions guidelines in that regard?