Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Plugin not working (possibly broke by commit 51396fed3f9634b2df5f042299a19d9fba5163f4) #73

Closed
dleidert opened this issue Dec 1, 2019 · 3 comments

Comments

@dleidert
Copy link

dleidert commented Dec 1, 2019

Hi there,

I packaged a lot of the Jekyll plugins for Debian GNU/Linux. I'm using Jekyll (3.8.3) myself and enabled the jekyll-last-modified-at plugin. But still page.last_modified_at stayed empty and {% last_modified_at %} was unrecognized. When I began to look into the issue I found that neither of the module classes gets loaded. In commit 51396fe the line Tag ; Hook was removed from jekyll-last-modified-at.rb. Was it intentional? Seems this is the culprit. Re-adding this line makes the plugin functional again.

@gjtorikian
Copy link
Owner

Hi there—I believe this was an errant change from bundle exec rubocop -a.

Could you let me know if adding these lines works for you:

    require 'jekyll-last-modified-at/tag'
    require 'jekyll-last-modified-at/hook'

If so, I'll push a new patch fix immediately.

@dleidert
Copy link
Author

dleidert commented Dec 1, 2019

This works too.

@dleidert
Copy link
Author

dleidert commented Dec 3, 2019

@gjtorikian : Thanks. Do you have any idea why your tests didn't reveal the issue? I'd suggest to add a test to catch this issue in the future.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants