Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: Fix crosscompilation installing to wrong directory #36

Merged
merged 1 commit into from
Jan 21, 2022

Conversation

fortysixandtwo
Copy link
Contributor

By using $(CC) instead of hardcoding gcc we make sure to get the
correct triplet that is being used for the installation directory.

Credits go to Helmut Grohne for providing a fix, see
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1003476

@fortysixandtwo fortysixandtwo mentioned this pull request Jan 13, 2022
3 tasks
@hartwork
Copy link
Contributor

hartwork commented Jan 20, 2022

My vote for merging, with this precise plan:

@gkdr @fortysixandtwo good?

@fortysixandtwo fortysixandtwo changed the base branch from master to dev January 21, 2022 00:07
@fortysixandtwo
Copy link
Contributor Author

fortysixandtwo commented Jan 21, 2022

Sounds good to me, just changed the target branch and rebased against dev.

Please ping me, once #37 is in so I can rebase (assuming @gkdr is fine with the proposed plan)

Edit: Also added the suggested changelog entry.

@fortysixandtwo fortysixandtwo force-pushed the fix_cross_build branch 2 times, most recently from e1e4517 to 230996d Compare January 21, 2022 01:02
@gkdr
Copy link
Owner

gkdr commented Jan 21, 2022

hi, thank you for the contribution!
i rebase the commit onto dev as a "pr merge", so unless there are conflicts to resolve i'm not sure any further action is even required.

one little request: could you please put your changelog item in the "fixed" section? 🙂

By using $(CC) instead of hardcoding gcc we make sure to get the
correct triplet that is being used for the installation directory.

Credits go to Helmut Grohne for providing a fix, see
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1003476
@fortysixandtwo
Copy link
Contributor Author

one little request: could you please put your changelog item in the "fixed" section? slightly_smiling_face

Oops, changed it just now ;)

@gkdr gkdr merged commit ffa29d3 into gkdr:dev Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants