Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake build system + msys2 windows binaries CI (fixes #6) #38

Merged
merged 8 commits into from
Feb 14, 2022

Conversation

hartwork
Copy link
Contributor

@hartwork hartwork commented Jan 29, 2022

Fixes #6

@gkdr this is 90% the same as gkdr/axc#32 but for libomemo. Would be nice to keep individual commits when merging (and they may ease review). Note that the topic of XML namespace compatibility (and defaults) probably needs to be discussed. I'm looking forward to review 🍻

@hartwork hartwork changed the base branch from master to dev January 29, 2022 17:33
@hartwork hartwork force-pushed the cmake-linux-msys2 branch 4 times, most recently from 10d2f7b to 87c9dbd Compare January 31, 2022 03:57
@hartwork
Copy link
Contributor Author

hartwork commented Feb 7, 2022

@gkdr rebased onto latest dev and ready for review now

@hartwork hartwork changed the title CMake build system + msys2 windows binaries CI CMake build system + msys2 windows binaries CI (fixes #6) Feb 7, 2022
@gkdr
Copy link
Owner

gkdr commented Feb 7, 2022

supposedly there's still merge conflicts? maybe because i touched the makefile?

@hartwork
Copy link
Contributor Author

hartwork commented Feb 7, 2022

supposedly there's still merge conflicts? maybe because i touched the makefile?

@gkdr it was the changelog this time, fixed and pushed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rework build
2 participants