-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMake build system + msys2 windows binaries CI (fixes #6) #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hartwork
force-pushed
the
cmake-linux-msys2
branch
4 times, most recently
from
January 31, 2022 03:57
10d2f7b
to
87c9dbd
Compare
hartwork
force-pushed
the
cmake-linux-msys2
branch
from
February 7, 2022 16:39
87c9dbd
to
a33c4b4
Compare
@gkdr rebased onto latest |
hartwork
changed the title
CMake build system + msys2 windows binaries CI
CMake build system + msys2 windows binaries CI (fixes #6)
Feb 7, 2022
supposedly there's still merge conflicts? maybe because i touched the makefile? |
hartwork
force-pushed
the
cmake-linux-msys2
branch
from
February 7, 2022 21:59
a33c4b4
to
da2fb2a
Compare
@gkdr it was the changelog this time, fixed and pushed now. |
hartwork
force-pushed
the
cmake-linux-msys2
branch
from
February 14, 2022 15:28
da2fb2a
to
09f9e58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6
@gkdr this is 90% the same as gkdr/axc#32 but for libomemo. Would be nice to keep individual commits when merging (and they may ease review). Note that the topic of XML namespace compatibility (and defaults) probably needs to be discussed. I'm looking forward to review 🍻