dependencies: sklearn -> scikit-learn #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
declaring `sklearn` as a dependency is going to be deprecated https://github.com/scikit-learn/sklearn-pypi-package
|
@gkhayes @ChristopherBilg would you kindly take a look? 🙇 |
|
Yup, good preventative maintenance. |
|
@ChristopherBilg thanks for the attention to it! |
|
@vpipkt Anytime! |
|
@ChristopherBilg i don't have premission to merge to this repo. Any action required on my part to get this merged? |
|
Nor do I, just need to wait on @gkhayes for that. |
|
i guess the next question is when we can expect a release with this change 🥺 |
|
@gkhayes @ChristopherBilg When can we expect a release with this change? |
|
That would be on @gkhayes to bump minor versions. |
|
@gkhayes can we expect a release with this update? |
|
@vpipkt @ChristopherBilg - Sorry about the delay, but I have been busy with my day job. Will try to get something out in the next few weeks, but I can't promise anything. |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
declaring
sklearnas a dependency is going to be deprecated https://github.com/scikit-learn/sklearn-pypi-package