-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backlight timeout brightness is hardcoded and too high #111
Comments
@hijae Would you be interested in working on this? |
Yes. i want to do. |
I noticed while working that even with the backlight set to 0, I can see that the screen is very dimly lit. |
Possibly, let's implement and then we can adjust as needed. |
OK, I will assign both to you, thank you. |
Thanks to #108 I reviewed the backlight timeout brightness handling ... and it sucks with multiple problems.
Let's start with the first problem:
64
If we look at the
ezBacklight::menu()
, the brightness slider goes down to48
, something I recall determining via trial and error on the original M5StickC.This means if we set minimum brightness at
48
, we actually increase brightness to64
during inactivity timeout, this is so wrong.Second problem:
64
is quite bright for the M5StickC Plus2 and M5Stack CoreI propose the following solutions:
ezBacklight
, sayezBacklight::getMinimumBrightness()
ezBacklight::getMinimumBrightness()
in:ezBacklight::loop()
during inactivityezBacklight::menu()
as the minimum brightness in the sliderThe text was updated successfully, but these errors were encountered: