Manually call the setter of speechDurationMs/silenceDurationMs when creating VadSilero
#17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en creating VadSilero When using the builder to create a VadSilero object, `speechDurationMs` and `silenceDurationMs` do not actually take effect, because they rely on the setter function of the field to trigger the update of `maxSpeechFramesCount` and `maxSilenceFramesCount`, and the construction parameters of kotlin will not trigger this operation Manually call the setters of `duration` parameters during init construction to ensure they are properly assigned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the builder to create a VadSilero object,
speechDurationMsandsilenceDurationMsdo not actually take effect, because they rely on the setter function of the field to trigger the update ofmaxSpeechFramesCountandmaxSilenceFramesCount, and the construction parameters of kotlin will not trigger this operationManually call the setters of
durationparameters during init construction to ensure they are properly assigned.