Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting cmdline to "neovim" doesn't disable firenvim's external cmdline #1442

Closed
odrling opened this issue Oct 25, 2022 · 3 comments
Closed

Comments

@odrling
Copy link

odrling commented Oct 25, 2022

  • OS Version: Gentoo Linux
  • Browser Version: Firefox 106.0.1
  • Browser Addon Version: 0.2.13
  • Neovim Plugin Version: 2f0ee85

What I tried to do

I am trying to disable the external cmdline from firenvim so I can use the interface from noice.nvim instead.

I've set the local settings:

vim.g.firenvim_config = {localSettings = {
    [".*"] = {cmdline = "neovim", priority = 0, takeover = "never"},
    ["https://[^/]*github\\.com/.*"] = {cmdline = "neovim", priority = 1, takeover = "always"}}}

What happened

Firenvim's cmdline appears on top of Noice's:

@glacambre
Copy link
Owner

Hi, thanks a lot for the interesting bug report :).

The settings you provided do disable Firenvim's command line, the problem is that Noice re-enables it. This is a fundamental issue at the neovim level: Noice attaches to Neovim and pretends to be a UI, but Neovim does not support providing different command line representations to differents UIs.

The workaround for current Firenvim versions is to only enable Noice when g:started_by_firenvim does not exist or is false. Ultimately I could provide a cmdline: "none" setting to prevent Firenvim from rendering the command line, but the proper solution really is at the neovim-level itself.

Nice colorscheme btw :)

@alerque
Copy link
Contributor

alerque commented Oct 26, 2022

I was just struggling with this one myself the other day too. I've been trying to get noice spun up in my own config, but having trouble with it in two places: Firenvim and Neovide (Rust based graphical wrapper, noice related conflict info in this issue).

I am able to disable it for the places it is trouble of course, but it would be nice to actually use with Firenvim. As such the mentioned cmdline: "none" option be nice to have.

glacambre added a commit that referenced this issue Nov 2, 2022
Fusing messages and cmdline isn't ideal, but as neovim doesn't offer a
way to get separate cmdline and messages, it's probably better not to
offer a second configuration option that only works conditional on the
"cmdline" setting.
glacambre added a commit that referenced this issue Nov 2, 2022
Fusing messages and cmdline isn't ideal, but as neovim doesn't offer a
way to get separate cmdline and messages, it's probably better not to
offer a second configuration option that only works conditional on the
"cmdline" setting.
@glacambre
Copy link
Owner

"cmdline":"none" is now implemented in the latest releases, which have been published. The new release is already available on addons.mozilla.org and will be automatically published on the chrome web store once it passes review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants