Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permit setting firenvim to use --remote instead of starting a new neovim instance #197

Closed
BlueDrink9 opened this issue Nov 2, 2019 · 9 comments · Fixed by #382
Closed
Labels
neovim-change This feature needs something to be implemented in neovim

Comments

@BlueDrink9
Copy link

BlueDrink9 commented Nov 2, 2019

Could a way of using nvr be set up, so that each new firenvim instance connects to an existing neovim process rather than having to start up a new instance?

Neovim isn't always instant to start, especially if configured for more ide-like editing. I'm very pleased that I can use vim to edit jupyter notebooks properly now - but starting a new editor instance every time I click a box is painful. Connecting to a server would salve this.

@glacambre
Copy link
Owner

glacambre commented Nov 2, 2019

Yes, it should be possible to implement something like --remote, this would just require you to do something like call firenvim#start_server({...}) if you want to start the neovim server yourself instead of having firenvim start it.

I'm disappointed to hear that startup is slow for you though and this is something I will fix regardless of whether and when --remote is implemented. It's unlikely that this is caused by your config since firenvim starts a neovim process before you ask for one, which means the slowness you're experiencing is the cost of creating the iframe + performing a websocket handshake + performing a first rendering.

@glacambre
Copy link
Owner

Work has started in the impl_single_server branch and is blocked by neovim/neovim#11646.

@glacambre
Copy link
Owner

glacambre commented Jan 12, 2020

Now blocked by neovim/neovim#3338.

@glacambre glacambre added the neovim-change This feature needs something to be implemented in neovim label Jan 13, 2020
@NilsIrl
Copy link
Contributor

NilsIrl commented Jan 20, 2020

neovim/neovim#11331 was merged. Closing neovim/neovim#3338

glacambre added a commit that referenced this issue Jan 25, 2020
Currently buggy if `:qall!` is used.

Closes #197
glacambre added a commit that referenced this issue Jan 26, 2020
Currently buggy if `:qall!` is used.

Closes #197
glacambre added a commit that referenced this issue Jan 26, 2020
Currently buggy if `:qall!` is used.

Closes #197
glacambre added a commit that referenced this issue Jan 26, 2020
Currently buggy if `:qall!` is used.

Closes #197
glacambre added a commit that referenced this issue Jan 26, 2020
Currently buggy if `:qall!` is used.

Closes #197
glacambre added a commit that referenced this issue Jan 26, 2020
Currently buggy if `:qall!` is used.

Closes #197
glacambre added a commit that referenced this issue Jan 26, 2020
Currently buggy if `:qall!` is used.

Closes #197
glacambre added a commit that referenced this issue Jan 26, 2020
Currently buggy if `:qall!` is used.

Closes #197
glacambre added a commit that referenced this issue Jan 26, 2020
Currently buggy if `:qall!` is used.

Closes #197
glacambre added a commit that referenced this issue Jan 26, 2020
Currently buggy if `:qall!` is used.

Closes #197
glacambre added a commit that referenced this issue Jan 26, 2020
Currently buggy if `:qall!` is used.

Closes #197
glacambre added a commit that referenced this issue Jan 26, 2020
Currently buggy if `:qall!` is used.

Closes #197
glacambre added a commit that referenced this issue Jan 26, 2020
Currently buggy if `:qall!` is used.

Closes #197
glacambre added a commit that referenced this issue Jan 26, 2020
Currently buggy if `:qall!` is used.

Closes #197
glacambre added a commit that referenced this issue Jan 26, 2020
Currently buggy if `:qall!` is used.

Closes #197
glacambre added a commit that referenced this issue Jan 26, 2020
Currently buggy if `:qall!` is used.

Closes #197
glacambre added a commit that referenced this issue Jan 26, 2020
Currently buggy if `:qall!` is used.

Closes #197
glacambre added a commit that referenced this issue Jan 26, 2020
Currently buggy if `:qall!` is used.

Closes #197
glacambre added a commit that referenced this issue Jan 26, 2020
Currently buggy if `:qall!` is used.

Closes #197
glacambre added a commit that referenced this issue Jan 26, 2020
Currently buggy if `:qall!` is used.

Closes #197
glacambre added a commit that referenced this issue Jan 26, 2020
Currently buggy if `:qall!` is used.

Closes #197
glacambre added a commit that referenced this issue Jan 26, 2020
Currently buggy if `:qall!` is used.

Closes #197
glacambre added a commit that referenced this issue Jan 26, 2020
Currently buggy if `:qall!` is used.

Closes #197
glacambre added a commit that referenced this issue Jan 26, 2020
Currently buggy if `:qall!` is used.

Closes #197
glacambre added a commit that referenced this issue Jan 26, 2020
Currently buggy if `:qall!` is used.

Closes #197
glacambre added a commit that referenced this issue Jan 26, 2020
Currently buggy if `:qall!` is used.

Closes #197
glacambre added a commit that referenced this issue Jan 26, 2020
Currently buggy if `:qall!` is used.

Closes #197
glacambre added a commit that referenced this issue Jan 26, 2020
Currently buggy if `:qall!` is used.

Closes #197
glacambre added a commit that referenced this issue Jan 26, 2020
Currently buggy if `:qall!` is used.

Closes #197
glacambre added a commit that referenced this issue Jan 26, 2020
Currently buggy if `:qall!` is used.

Closes #197
glacambre added a commit that referenced this issue Jan 26, 2020
Currently buggy if `:qall!` is used.

Closes #197
glacambre added a commit that referenced this issue Jan 27, 2020
Currently buggy if `:qall!` is used.

Closes #197
glacambre added a commit that referenced this issue Feb 1, 2020
Currently buggy if `:qall!` is used.

Closes #197
glacambre added a commit that referenced this issue Feb 1, 2020
Currently buggy if `:qall!` is used.

Closes #197
glacambre added a commit that referenced this issue Feb 2, 2020
Currently buggy if `:qall!` is used.

Closes #197
glacambre added a commit that referenced this issue Feb 2, 2020
Currently buggy if `:qall!` is used.

Closes #197
glacambre added a commit that referenced this issue Feb 4, 2020
Currently buggy if `:qall!` is used.

Closes #197
glacambre added a commit that referenced this issue Feb 15, 2020
Currently buggy if `:qall!` is used.

Closes #197
glacambre added a commit that referenced this issue Feb 18, 2020
Currently buggy if `:qall!` is used.

Closes #197
@glacambre
Copy link
Owner

Now implemented on master, either build from source or wait for a new release. See this section of the readme to learn how to use it :).

@NilsIrl
Copy link
Contributor

NilsIrl commented Feb 18, 2020

Does it require neovim built from neovim/neovim#11821 at least(i.e. any commit since this was merged)?

@glacambre
Copy link
Owner

Yep, that's what I mean by "this requires a Neovim compiled at commit a2efc9c or more recent." :)

@NilsIrl
Copy link
Contributor

NilsIrl commented Feb 18, 2020

Yep, that's what I mean by "this requires a Neovim compiled at commit a2efc9c or more recent." :)

idk why, the way I read it, I wasn't sure if this was referring to firenvim or nvim.

Anyway, as long as you're not using the persistent server, you're fine right?

@glacambre
Copy link
Owner

glacambre commented Feb 18, 2020

Anyway, as long as you're not using the persistent server, you're fine right?

Yep, should be (except for #428 which I intend to fix ASAP).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
neovim-change This feature needs something to be implemented in neovim
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants