Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update loadBedTrackFromFile function to ignore shiny query strings #88 #89

Merged
merged 3 commits into from
Aug 30, 2024
Merged

Update loadBedTrackFromFile function to ignore shiny query strings #88 #89

merged 3 commits into from
Aug 30, 2024

Conversation

parv-sachdeva
Copy link
Contributor

@parv-sachdeva parv-sachdeva commented Aug 27, 2024 •
edited
Loading

Fix for issue #88

Updated the dataURL code to remove query strings and use the base url:

var dataURL = window.location.href.split('?')[0] + bedFile;

@parv-sachdeva parv-sachdeva changed the title Fixes #88 Fixes gladkia/igvShiny#88 Aug 27, 2024
@parv-sachdeva parv-sachdeva changed the title Fixes gladkia/igvShiny#88 Update loadBedTrackFromFile function to ignore shiny query strings #88 Aug 27, 2024
gladkia
gladkia reviewed Aug 29, 2024
View reviewed changes
Copy link
Owner

@gladkia gladkia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)!
Please bump version and news.md :).

@parv-sachdeva
Copy link
Contributor Author

Hello @gladkia

I have updated the version to v1.0.5 and also updated NEWS.md.

Best,
Parv

@gladkia gladkia merged commit 648a469 into gladkia:master Aug 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gladkia gladkia gladkia left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@parv-sachdeva @gladkia