Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass the USP string to Amazon #17

Merged
merged 2 commits into from
Aug 27, 2020
Merged

Pass the USP string to Amazon #17

merged 2 commits into from
Aug 27, 2020

Conversation

kmjennison
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #17 into master will increase coverage by 0.06%.
The diff coverage is 96.96%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
+ Coverage   98.26%   98.33%   +0.06%     
==========================================
  Files          30       31       +1     
  Lines         578      599      +21     
  Branches       96       99       +3     
==========================================
+ Hits          568      589      +21     
  Misses          9        9              
  Partials        1        1              
Impacted Files Coverage Δ
src/utils/logger.js 97.14% <91.66%> (ø)
src/providers/amazon/amazonBidder.js 100.00% <100.00%> (ø)
src/utils/getUSPString.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69eadf1...7b8474b. Read the comment docs.

@kmjennison kmjennison merged commit 4bd87f7 into master Aug 27, 2020
@kmjennison kmjennison deleted the kevin/amazon-usp branch August 27, 2020 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants