Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change pageLevelKeyValues to be an object #27

Merged
merged 1 commit into from
Apr 20, 2021
Merged

Conversation

amaliwanag2
Copy link

No description provided.

@codecov
Copy link

codecov bot commented Apr 19, 2021

Codecov Report

Merging #27 (a2cf3e5) into master (59b0fc6) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #27      +/-   ##
==========================================
- Coverage   96.76%   96.74%   -0.03%     
==========================================
  Files          31       31              
  Lines         680      675       -5     
  Branches      145      142       -3     
==========================================
- Hits          658      653       -5     
  Misses         21       21              
  Partials        1        1              
Impacted Files Coverage Δ
src/config.js 98.46% <100.00%> (-0.14%) ⬇️
src/google/setUpGoogleAds.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59b0fc6...a2cf3e5. Read the comment docs.

Copy link
Contributor

@kmjennison kmjennison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍝

@kmjennison kmjennison merged commit d4bc048 into master Apr 20, 2021
@kmjennison kmjennison deleted the alec/TFAC-170 branch April 20, 2021 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants