Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Yahoo from Prebid #52

Merged
merged 1 commit into from
Apr 12, 2023
Merged

Remove Yahoo from Prebid #52

merged 1 commit into from
Apr 12, 2023

Conversation

kmjennison
Copy link
Contributor

FYI, steps in this process:

  • removed the Yahoo module from Prebid's modules.json
  • yarn run prebid:build: built Prebid from source, which generates the pb.js that contains Prebid base code and all modules
  • modified our Prebid config to remove Yahoo from the ad unit configuration

@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (14bc439) 96.73% compared to head (cc545d6) 96.73%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #52   +/-   ##
=======================================
  Coverage   96.73%   96.73%           
=======================================
  Files          31       31           
  Lines         673      673           
  Branches      144      144           
=======================================
  Hits          651      651           
  Misses         21       21           
  Partials        1        1           
Impacted Files Coverage Δ
src/providers/prebid/prebidBidder.js 95.65% <ø> (ø)
src/utils/test-fixtures.js 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kmjennison kmjennison merged commit c086ebe into master Apr 12, 2023
@kmjennison kmjennison deleted the kevin/remove-yahoo branch April 12, 2023 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant