Some change for normal usable #5
Conversation
I appreciate your efforts, but I think changes will be necessary before I can merge these patches. I will comment on each. |
I don't think there's a need for git commit messages to contain "add", "chg", or "fix" tags. |
On balance, if you changed the commit messages, I'd merge the first four of these commits. The last one has some problems -- I'll comment there. |
I've change patch and remove tags :-) |
Bibliographic :date :slug supported, hope you like it. |
As your wish, I've fix fwolf@befa429 in patch fwolf@6704ead . There are several patch between these 2 commit, maybe hard to rollback for me, Or, may you suggestion me better way to rewind without lost these middle commit ? thanks. |
I would prefer separate pull requests. You can create new branches using git checkout -b. Create a new branch for commits 1-4, a new branch for 6-7, a new branch for 8-9, one for 10, and one for 11. For each branch, you can do git rebase -i to choose only those patches. The other branches won't be changed when you do this. I don't think these commits depend on each other that much (but I haven't read all of them). You can do gitk --all to see where all the branches are. If you open pull requests for each group of patches, I will be able to merge just the ones I like. Plus, you will be able to discard patch 5. I like this because I don't know if I want to merge 8 or 9. |
OK, I've update these commit, here is summary by origin #id:
I'm not using git rebase completely, Do you think create many branch and push to github and then send pull request is complicate ? Is this way ok ? I'll try later. |
One other thing is that the first line of git commit messages shouldn't end in a period. (This is very minor.) Make the minor change to "Better fields insert" and I'll merge this. |
In default, tags are retrieved without 0 count tags, which cause update of blog draft create new tag prompt every time.
wp.getTags, wp.getCatetories are obsolete in WordPress 3.4.
Wish all goes fine this time. |
Minor cleanups and robustness
This is a good project, but some far for normal usable, at lease for me.
So I'm trying to make it workable for me.