Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible regression / T_PAAMAYIM_NEKUDOTAYIM bad handler #107

Closed
ichiriac opened this issue Dec 27, 2017 · 2 comments
Closed

Possible regression / T_PAAMAYIM_NEKUDOTAYIM bad handler #107

ichiriac opened this issue Dec 27, 2017 · 2 comments
Assignees
@ichiriac
Labels
bug PARSER php7 question
Milestone
2.2.0

Comments

@ichiriac
Copy link
Member

This line is strange / not sur it should be handled, and the suppressError mode is not handled :
https://github.com/glayzzle/php-parser/blame/master/src/parser/variable.js#L131

Introduced from :
21de90b

Should check PHP support & implement missing features
@ichiriac ichiriac added this to the 2.2.0 milestone Dec 27, 2017
@ichiriac ichiriac self-assigned this Dec 27, 2017
@ichiriac
Copy link
Member Author

Ok, this feature was introduced from PHP 7 :
https://github.com/php/php-src/blob/master/Zend/zend_language_parser.y#L1097

@ichiriac
Copy link
Member Author

Here some parsing errors :

  • $var::arg::!; should fail
  • $var::foo::bar should fail (even in PHP7)

ichiriac added a commit that referenced this issue Dec 27, 2017
@ichiriac
#107 - self & parent are identifiers to be consistent with PHP tokens
a9fd202
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ichiriac ichiriac

Labels
bug PARSER php7 question
Projects
None yet
Milestone
2.2.0
Development

No branches or pull requests
1 participant
@ichiriac