Use short form for type casts #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ichiriac
reviewed
Dec 26, 2017
| @@ -272,7 +272,7 @@ module.exports = { | |||
| return this.node('cast')('int', this.next().read_expr()); | |||
|
|
|||
| case this.tok.T_DOUBLE_CAST: | |||
| return this.node('cast')('double', this.next().read_expr()); | |||
| return this.node('cast')('float', this.next().read_expr()); | |||
There was a problem hiding this comment.
not sure in PHP but in principle double and float have not the same precision, I'll check this
There was a problem hiding this comment.
😄 got it from https://github.com/glayzzle/php-parser/blob/master/src/lexer.js#L111, actually there is only one token to these 3 casts types
There was a problem hiding this comment.
Exactly - they are just aliases in PHP 😉
ichiriac
reviewed
Dec 26, 2017
| @@ -142,28 +142,35 @@ describe('Test expressions', function() { | |||
| }); | |||
|
|
|||
| it('test cast', function() { | |||
| var typesWithAlias = { | |||
|
hi @czosel, I'll release it under 2.2.0 soon, I need to fix another little regression elsewhere, almost done |
|
Awesome! Thanks to your support I'm positive we'll have a working prettier implementation for PHP soon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
typeof types casts has been inconsistent: Sometimes, an alias/long form was used (e.g.boolean), other times the short form (e.g.int). This PR changes this by always using the short form.Please also see prettier/plugin-php#5 (comment) for some more context.
Thanks for your feedback in advance!