Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add tests #12

Merged
merged 1 commit into from
Apr 3, 2022
Merged

test: Add tests #12

merged 1 commit into from
Apr 3, 2022

Conversation

vstreame
Copy link
Contributor

@vstreame vstreame commented Apr 2, 2022

These were mostly copy/pasted from the gleam_httpc test cases. Because httpc still uses gleam_http 2.0 APIs (for now) I've added gleam_hackney as a dev HTTP client.

Closes #1

These were mostly copy/pasted from the `gleam_httpc` test cases. Because
`httpc` still uses `gleam_http` 2.0 APIs (for now) I've added
`gleam_hackney` as a dev HTTP client for now.
Copy link
Member

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant, thank you.

We should add these to Elli too. I've made an issue.

@lpil lpil merged commit 04dd0ef into gleam-lang:main Apr 3, 2022
@vstreame vstreame deleted the E/add-tests branch April 3, 2022 20:10
@vstreame
Copy link
Contributor Author

vstreame commented Apr 3, 2022

@lpil I can work on that!

@vstreame
Copy link
Contributor Author

vstreame commented Apr 3, 2022

@lpil gleam-lang/elli#16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write tests
2 participants