Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add internal annotation #2558

Merged
merged 18 commits into from
Mar 25, 2024
Merged

Add internal annotation #2558

merged 18 commits into from
Mar 25, 2024

Conversation

giacomocavalieri
Copy link
Member

@giacomocavalieri giacomocavalieri commented Jan 21, 2024 •
edited
Loading

This PR adds the @internal annotation, closing #2486

Why is this a WIP PR?

@DanielSherlock
Copy link

(I don't rust, so feel free to ignore me completely.)

I joined the stream late so was curious to look at parts of the code again after, and noticed some things that seem suspicious about completions for types. Hopefully the comments I added are getting at the right bits of code for the issue.

@giacomocavalieri
Copy link
Member Author

Thank you @DanielSherlock for pointing this out! I've fixed the bug and added some tests to make sure that internal types do appear in the completions for the same module they're defined in

@DanielSherlock
Copy link

Glad I could help! 👍

@giacomocavalieri giacomocavalieri marked this pull request as ready for review January 31, 2024 21:05
@lpil
Copy link
Member

lpil commented Feb 12, 2024

Could you rebase on main please? 🙏

lpil
lpil reviewed Feb 12, 2024
View reviewed changes
compiler-core/src/analyse.rs Outdated Show resolved Hide resolved
compiler-core/src/language_server/engine.rs Outdated Show resolved Hide resolved
compiler-core/src/language_server/engine.rs Outdated Show resolved Hide resolved
@lpil
Copy link
Member

lpil commented Mar 6, 2024

Is this WIP @giacomocavalieri ?

@giacomocavalieri
Copy link
Member Author

Yes I still have to finish addressing your review comments, I'll be working on this shortly!

@giacomocavalieri giacomocavalieri marked this pull request as draft March 12, 2024 14:41
@giacomocavalieri giacomocavalieri marked this pull request as ready for review March 22, 2024 12:56
@giacomocavalieri
Copy link
Member Author

Turning public + internal into a single publicity attribute turned out to be quite the chunky refactoring but I think this is finally ready for review @lpil 🎉

lpil
lpil reviewed Mar 22, 2024
View reviewed changes
Copy link
Member

@lpil lpil left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!! And what an effort 💪 I've left a few small notes inline. Thank you!

compiler-core/src/docs.rs Show resolved Hide resolved
compiler-core/src/docs.rs Outdated Show resolved Hide resolved
compiler-core/src/javascript/typescript.rs Outdated Show resolved Hide resolved
compiler-core/src/language_server/engine.rs Show resolved Hide resolved
compiler-core/src/language_server/engine.rs Outdated Show resolved Hide resolved
compiler-core/src/language_server/engine.rs Outdated Show resolved Hide resolved
compiler-core/src/language_server/engine.rs Outdated Show resolved Hide resolved
compiler-core/src/language_server/tests/completion.rs Outdated Show resolved Hide resolved
compiler-core/src/language_server/tests/completion.rs Outdated Show resolved Hide resolved
lpil
lpil approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!!

@lpil lpil merged commit 55f5275 into gleam-lang:main Mar 25, 2024
11 checks passed
@giacomocavalieri giacomocavalieri deleted the internal branch March 25, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielSherlock DanielSherlock DanielSherlock left review comments

@lpil lpil lpil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@giacomocavalieri @DanielSherlock @lpil