Store formatted variables in a String #3484
Conversation
This fixes compilation errors when compiling with slightly less recent rust compilers, e.g. 1.78.0 and 1.77.1. The performance overhead of formatting the string here is neglegible in any case since the string is only discarded if there are zero or one variables, in which case the extra call to `join` is very cheap.
|
Hello! What's the motivation for this? We don't support other Rust versions and we provide precompiled binaries for people to use. |
|
Personally, I am not a fan of precompiled tools especially when the resulting binaries are not fully reproducible but that is a matter of taste. This is the only change that would enable retaining compatibility with a rustc version that was just released this May. I'd totally understand if the final decision is not to merge and just to raise the MSRV. |
|
I'm guessing this is due to Nix? That build tool produces more support requests and takes up more time than all other build tools and operating systems combined. It's clearly documented what we support, and we provide precompiled binaries that work on NixOS without modification to the operating system or the binary, so I don't understand why there are frequent requests to change things in Gleam to facilitate Nix. Downloading the binary and verifying the checksum is reproducible in the same way that downloading the source, verifying its checksum, and then applying deterministic compilation is reproducible. It is also is known to work, unlike the buggy Nix produced binaries that people report bugs for. I'm sorry for being abrasive here but the behaviour of the Nix community is very tiring as an open source maintainer. |
This PR fixes a compilation error when compiling with slightly less recent rust compilers, e.g. 1.78.0 and 1.77.1.
The performance overhead of formatting the string here is negligible in any case since the string is only discarded if there are zero or one variables, in which case the extra call to
joinis very cheap.