Fix function calls inference in pipes #3525
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, why did I make this change?
In some cases
return_.fn_arity()
was returningNone
, becausereturn_
was not a function type, butType::Var { type_ }
. Which does not have an arity.Why is it safe not to check the arity here? Because it will be checked in the second
self.expr_typer.do_infer_call_with_known_fun
call here:gleam/compiler-core/src/type_/pipe.rs
Lines 249 to 260 in 72f4ac9
Closes #3515