Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimise html_escape #76

Merged
merged 3 commits into from
May 25, 2024
Merged

Conversation

giacomocavalieri
Copy link
Contributor

This PR replaces escape_html's implementation with an optimised version to make it faster and more memory efficient

src/wisp.gleam Show resolved Hide resolved
src/wisp.gleam Outdated Show resolved Hide resolved
@lpil
Copy link
Collaborator

lpil commented May 24, 2024

Super nice!!! I left a Q

src/wisp.gleam Outdated Show resolved Hide resolved
@lpil
Copy link
Collaborator

lpil commented May 24, 2024

Changelog please!

Copy link
Collaborator

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heck yeah!

@lpil lpil merged commit 51aa03a into gleam-wisp:main May 25, 2024
1 check failed
@giacomocavalieri giacomocavalieri deleted the optimise-escape branch May 25, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants