Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase mist version to 1.2.0 #77

Merged
merged 2 commits into from
Jun 5, 2024
Merged

Conversation

kwmiebach
Copy link

@kwmiebach kwmiebach commented Jun 1, 2024

Hello,

This PR increases the mist version to >= 1.2.0 ... .

I was trying out the examples and noticed they were not compiling:

error: Unknown module field
   ┌─ /app/wisp/examples/00-hello-world/build/packages/mist/src/mist/internal/websocket.gleam:47:39
   │
47 │       let assert Ok(mask_value) = list.at(masks, index % 4)
   │                                       ^^^ Did you mean `last`?

The module `gleam/list` does not have a `at` value.

I found that example 00 and 01 seem to work with the current PR.

I did not try out 02 ff and neither the main application, so you probably should not merge this.

Copy link
Collaborator

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also update the changelog to note that the Mist requirement has been updated to >= 1.2.0 please. Thanks

@kwmiebach
Copy link
Author

kwmiebach commented Jun 3, 2024

I updated the changelog and the branch. But now I noticed this in the changelog, see last line of quote:

$ head CHANGELOG.md -n11

# Changelog

## Unreleased

- The `mist` version constraint has been increased to >= 1.2.0.
- The `escape_html` function in the `wisp` module has been optimised.

## v0.14.0 - 2024-03-28

- The `mist` version constraint has been relaxed to permit 0.x or 1.x versions.

It had been relaxed to 0.x just before. I am not sure if this PR should be merged. Maybe there was a reason to relax the constraint to 0.x?

@kwmiebach
Copy link
Author

It looks like the critical list.at() had been removed in this commit line rawhat/mist@c5372b#r142703852

This commit is between mist v1.0.0 and v1.1.0.

Previously line 46 of src/mist/internal/websocket.gleam had been, see initial error message above:

let assert Ok(mask_value) = list.at(masks, index % 4)

@lpil
Copy link
Collaborator

lpil commented Jun 5, 2024

It had been relaxed to 0.x just before. I am not sure if this PR should be merged. Maybe there was a reason to relax the constraint to 0.x?

It was relaxed to permit 1.x

Copy link
Collaborator

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@lpil lpil merged commit 44326fb into gleam-wisp:main Jun 5, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants