Add set_logger_level function #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpil
reviewed
Jun 21, 2024
src/wisp.gleam
Outdated
| /// [1]: https://www.erlang.org/doc/man/logger | ||
| /// | ||
| pub type LogLevel = | ||
| logging.LogLevel |
There was a problem hiding this comment.
Could you create a new custom type here for the log level? To avoid making that library part of the public API, and to avoid the users having to import 2 modules.
src/wisp.gleam
Outdated
| /// | ||
| /// [1]: https://www.erlang.org/doc/man/logger | ||
| /// | ||
| pub fn set_logger_level(log_level: LogLevel) { |
There was a problem hiding this comment.
The return annotation is missing!
|
Comments solved! |
lpil
approved these changes
Jun 23, 2024
Done! |
lpil
reviewed
Jun 30, 2024
src/wisp.gleam
Outdated
| Emergency | ||
| Alert | ||
| Critical | ||
| Error |
There was a problem hiding this comment.
Ah! This is overriding the prelude Error type resulting in type errors. Perhaps they can all be suffixed with Level?
There was a problem hiding this comment.
Uuhh my lsp didn't caught that, my bad!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I've noticed the logging library has been updated with the new set_logger_level function. I've thought that adding a wrapper around that function in wisp would be nice, altough it could be divided into many smaller functions as set_log_level_to_info() and the like. What do you think?