Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gleam_json dependency constraint #82

Conversation

giacomocavalieri
Copy link
Contributor

No description provided.

@lpil
Copy link
Collaborator

lpil commented Jul 5, 2024

What's the motivation here? I thought we were deliberately holding back on this one?

@giacomocavalieri
Copy link
Contributor Author

Oops sorry I had no idea it was being intentionally held back. My problem is I ran into dependency resolution errors trying to add lustre_dev_tools as a dependency:

> gleam new wibble
> cd wibble
> gleam add lustre
> gleam add lustre_dev_tools --dev

error: Dependency resolution failed

An error occurred while determining what dependency packages and
versions should be downloaded.
The error from the version resolver library was:

Unable to find compatible versions for the version constraints in your
gleam.toml. The conflicting packages are:

- wibble
- lustre_dev_tools
- wisp
- gleam_json

The error message is not super useful but I thought the problem might be with wisp being too restrictive with the constraint.

@lpil
Copy link
Collaborator

lpil commented Jul 8, 2024

Brew is stuck on 26 for some reason so if we upgrade everything to the new gleam_json most macOS users won't be able to use them. This is why Lustre docs are saying to use the old version of gleam_json currently. Looks like you've installed the new one there.

@pmbanugo
Copy link

I guess this can be fixed/merged, Erlang OTP on homebrew mac is now on 27. I guess that's the blocker, according to this comment

@Papipo
Copy link

Papipo commented Sep 25, 2024

Why would someone prefer to use brew over something like asdf? I mean, can't just asdf be recommended over brew?

@giacomocavalieri
Copy link
Contributor Author

Even if we recommended asdf it wouldn't change the fact that loads of macOS users will be using brew and breaking a really common library for them would be quite bad.

Personally I use brew and like how simple it is :)

@lpil
Copy link
Collaborator

lpil commented Sep 30, 2024

Would you mind rebasing on main please 🙏

@giacomocavalieri
Copy link
Contributor Author

Done!

@lpil
Copy link
Collaborator

lpil commented Oct 11, 2024

Sorry Jak, I merged another PR that had this change also

@lpil lpil closed this Oct 11, 2024
@giacomocavalieri giacomocavalieri deleted the update_gleam_json_dep branch October 11, 2024 16:07
@giacomocavalieri
Copy link
Contributor Author

No worries!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants