Headless rework to implement headlessWait in javascript and make headless testable #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentinedwv
changed the title
Fixes #152 add a test that is expected to fail, with 1 JSONld returned.
Works. leaving in the headlessWait incase another issue that requires its.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses headless issues #152, and #127
Added code to test the Headless sans need to upload file to s3.
Implemented a sleep in the headless javascript to allow for a wait for the page to be rendered, even though DOMContentEventFired has been fired.
As suggested bymafredri now using LoadEventFired
Leaving in the headless wait incase it is needed later ;0