You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
However, this caused an issue for us. We did the following:
Add foo.one in base locale, use translate-missing to add it to all locales
Add foo.other in base locale, use translate-missing to add it to all locales. This did not work.
We have a sanity check on CI which runs i18n-tasks missing -t diff,plural - this also did not catch the missing key.
The reason being that there is just one node, and it does not contain %{count} - which is to be expected if the key is one. This was originally just meant to cover only other keys, but was later amended to cover all possible keys in review.
It seems this was added solely to cover the special case mentioned in #310. In the meantime it became possible to ignore keys when checking plurals (see b04a9cf). I suggest removing this hardcoded special case (ie. the entire non_plural_other?-method), and instead use the ignore config for this case.
The text was updated successfully, but these errors were encountered:
This code was in #312 added to not falsely report "lonely" other keys:
i18n-tasks/lib/i18n/tasks/plural_keys.rb
Lines 60 to 62 in 5a6b02b
However, this caused an issue for us. We did the following:
foo.one
in base locale, usetranslate-missing
to add it to all localesfoo.other
in base locale, usetranslate-missing
to add it to all locales. This did not work.i18n-tasks missing -t diff,plural
- this also did not catch the missing key.The reason being that there is just one node, and it does not contain
%{count}
- which is to be expected if the key isone
. This was originally just meant to cover onlyother
keys, but was later amended to cover all possible keys in review.It seems this was added solely to cover the special case mentioned in #310. In the meantime it became possible to ignore keys when checking plurals (see b04a9cf). I suggest removing this hardcoded special case (ie. the entire
non_plural_other?
-method), and instead use theignore
config for this case.The text was updated successfully, but these errors were encountered: