ErbAst: Handles block calls #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes glebm#424 by allowing blocks to be parsed by ignoring `do`. - Adds specs for block calls. - Changes structure for erb tests to test relative keys as well. - Inspired by https://github.com/Shopify/better-html/blob/087943ffd2a5877fa977d71532010b0c91239519/lib/better_html/test_helper/ruby_node.rb#L24
davidwessman
commented
Mar 24, 2022
| @@ -48,7 +48,7 @@ def initialize(path:, pos:, line_num:, line_pos:, line:, raw_key: nil, default_a | |||
| # rubocop:enable Metrics/ParameterLists | |||
|
|
|||
| def inspect | |||
| "Occurrence(#{@path}:#{@line_num}:#{@line_pos}:#{@pos}:#{@raw_key}:#{@default_arg}:#{@line})" | |||
There was a problem hiding this comment.
@glebm Not sure what you think about this, can revert it 🙂
There was a problem hiding this comment.
"#{@path}:#{@line_num}" is standard notation, let's remove the field names there but keep the rest
There was a problem hiding this comment.
Going to merge this as-is for now and release 1.0.2 anyway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes With the new parser, some key usage is not found #424
Adds more tests for erb blocks and relative keys
Occurence: Adds keys to inspect string