Fix 'config' option usage in CLI #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool! @geoffharcourt Can you see if this solves your problems? |
|
Woot! This fixed it! @shev-vadim-net thanks for the find and the fix! We use i18n-tasks in two different setups, so this lets us remove a massive hack we had been using (copying config files over the canonical location). |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the #409 issue.
As I understand the
configoption is not fully added into the gem. It's used only in theI18n::Tasks::BaseTask.newand nowhere else. This change just removesconfigfrom the arguments. Now all the CLI commands work as expected when providing a custom configuration file.