Fix private method called for warn deprecated #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e existing translation files to include the 'pt-pt' as its locale in stead of simply 'pt'
…nsidered a private method and can be used
|
Thanks! Can you please fix the lint error? |
kerim1510
pushed a commit
to ansdelft/i18n-tasks
that referenced
this pull request
Jul 13, 2023
benjaminwols
deleted the
fix-private-method-called-for-warn-deprecated
branch
benjaminwols
restored the
fix-private-method-called-for-warn-deprecated
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have encountered a problem when trying to translate from Portuguese ("pt") to English without using the Portuguese sub locale ("pt-pt"). Which caused a
private method 'warn_deprecated' called for I18n::Tasks::BaseTaskThe use of
module_functionini18n/tasks/logging.rbcauses the methods to be made private and therefore makes it unable to call thewarn_deprecatedmethod in for example/tasks/translators/deepl_translator.rband/tasks/translators/google_translator.rb.This change could potentially fix the issue in #348 as well.