Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ast_matchers for default_i18n_subject matcher in config template #539

Merged
merged 2 commits into from
Dec 10, 2023
Merged

Use ast_matchers for default_i18n_subject matcher in config template #539

merged 2 commits into from
Dec 10, 2023

Conversation

Bilka2
Copy link
Contributor

@Bilka2 Bilka2 commented Dec 10, 2023

Same change as #512 did for the rails_model_matcher. And update the config template as well.

davidwessman
davidwessman approved these changes Dec 10, 2023
View reviewed changes
Copy link
Collaborator

@davidwessman davidwessman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool 😊 does the old way of requiring still work?

@Bilka2
Copy link
Contributor Author

Bilka2 commented Dec 10, 2023

does the old way of requiring still work?

Yes, old configurations with the require and add_ast_matcher call directly in the yml keep working. It was the same for #512 with the rails model matcher.

@glebm glebm merged commit 8ed31b2 into glebm:main Dec 10, 2023
6 checks passed
@Bilka2 Bilka2 deleted the require-default-i18n-subject-matcher branch December 10, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidwessman davidwessman davidwessman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Bilka2 @davidwessman @glebm