Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow predicate to be subset of props #27

Closed
wants to merge 1 commit into from

Conversation

hartzis
Copy link
Contributor

@hartzis hartzis commented Oct 20, 2015

This allows for the predicate to be an actual subset of the props. Solves what we were going for with #22 , and doesn't break any of the current tests.

Please let us know if this is this the direction you were going with Expand subTree functions to accept (selector, predicate).? #9 (comment)

@glenjamin
Copy link
Owner

The tests are a bit light on this area - the intention was for this to be available as subTreeLike - to match the existing findComponentLike

@hartzis
Copy link
Contributor Author

hartzis commented Oct 20, 2015

subTreeLike and everySubTreeLike will definitely solve what we are trying to do with #22

Apologies, for missing #9 (comment).

We are trying to not tie ourselves to html structure/presentation (classes/ids) and are excited to get our hands on those methods.

@glenjamin
Copy link
Owner

I'm going to close this, but feel free to reopen if you want to add the Like methods.

@glenjamin glenjamin closed this Oct 21, 2015
@hartzis
Copy link
Contributor Author

hartzis commented Oct 21, 2015

Awesome, I'll give it a whirl today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants